Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-17.0] Refactor Upgrade downgrade tests (#14782) #14831

Merged
merged 5 commits into from
Dec 27, 2023

Conversation

vitess-bot[bot]
Copy link
Contributor

@vitess-bot vitess-bot bot commented Dec 20, 2023

Description

This is a backport of #14782

Copy link
Contributor Author

vitess-bot bot commented Dec 20, 2023

Hello @GuptaManan100, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 14831 -R vitessio/vitess
git reset --hard origin/release-17.0
git cherry-pick -m 1 ff62da9bc5012022e552be20eda6d8401684fd15

Copy link
Contributor Author

vitess-bot bot commented Dec 20, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@github-actions github-actions bot added this to the v17.0.5 milestone Dec 20, 2023
@harshit-gangal harshit-gangal mentioned this pull request Dec 20, 2023
21 tasks
@harshit-gangal harshit-gangal modified the milestones: v17.0.5, v17.0.6 Dec 20, 2023
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 force-pushed the backport-14782-to-release-17.0 branch from 6cabd63 to ad3317a Compare December 21, 2023 12:15
@GuptaManan100 GuptaManan100 removed the Skip CI Skip CI actions from running label Dec 21, 2023
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
@GuptaManan100 GuptaManan100 marked this pull request as ready for review December 25, 2023 14:14
Signed-off-by: Manan Gupta <manan@planetscale.com>
Signed-off-by: Manan Gupta <manan@planetscale.com>
Copy link
Contributor

@shlomi-noach shlomi-noach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

percona-xtrabackup-24 errors seem unrelated to this PR.

@GuptaManan100
Copy link
Member

The unit test failure is being fixed in #14860

@GuptaManan100 GuptaManan100 merged commit 6e73e2e into release-17.0 Dec 27, 2023
198 of 199 checks passed
@GuptaManan100 GuptaManan100 deleted the backport-14782-to-release-17.0 branch December 27, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants